Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: add user to CompletionRequest #9

Merged
merged 1 commit into from
May 7, 2022
Merged

Conversation

Stuie
Copy link
Contributor

@Stuie Stuie commented May 6, 2022

See documentation: https://beta.openai.com/docs/api-reference/completions/create

Version bump to 1.0.1

Please let me know if there's something else I should do, or if I contributed incorrectly in some way.

@Stuie
Copy link
Contributor Author

Stuie commented May 7, 2022

I'm looking at the tests.

@Stuie
Copy link
Contributor Author

Stuie commented May 7, 2022

Seems like a lot of the failing tests are because of the missing OPENAI_API_KEY header. Those tests pass for me, locally, if I have that header specified. I see your build.yml file includes the key, so I'm not sure what's going wrong.

The only failing test in TestOpenAI on my machine is files[jvm] which I don't think has anything to do with my change.

Copy link
Owner

@aallam aallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@aallam aallam merged commit e8a3aca into aallam:main May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants